Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug: abount dependency injection #1475

Merged
merged 1 commit into from Mar 23, 2020
Merged

fix bug: abount dependency injection #1475

merged 1 commit into from Mar 23, 2020

Conversation

@rocinantex
Copy link
Contributor

rocinantex commented Mar 23, 2020

fix the issue: #1468

@rocinantex rocinantex requested a review from kataras as a code owner Mar 23, 2020
@kataras

This comment has been minimized.

Copy link
Owner

kataras commented Mar 23, 2020

Thanks @rocinantex. You, correctly, did that on the master branch as I proposed you, which is under development and will be merged with v12 branch, that's why you shouldn't re-push the PR in v12 branch too, we will have issues on merging... but I will fix them as always...

@kataras kataras merged commit b6ac394 into kataras:v12 Mar 23, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
kataras added a commit that referenced this pull request Mar 24, 2020
@rocinantex

This comment has been minimized.

Copy link
Contributor Author

rocinantex commented Mar 24, 2020

Thanks @rocinantex. You, correctly, did that on the master branch as I proposed you, which is under development and will be merged with v12 branch, that's why you shouldn't re-push the PR in v12 branch too, we will have issues on merging... but I will fix them as always...

Okay, I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.