Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix open redirect #972

Merged
merged 2 commits into from Apr 21, 2018

Conversation

Projects
None yet
3 participants
@wozz
Copy link
Contributor

commented Apr 20, 2018

Fix open redirect by using strings.Trim.

Another option would be to use path.Clean similar to here, but I'm unsure of side effects that may have for this use case: https://github.com/golang/go/blob/master/src/net/http/server.go#L2034

See a PoC of this issue with this link: https://iris-go.com//google.com/

Fix open redirect
Fix open redirect by using strings.Trim.

Another option would be to use path.Clean similar to here, but I'm unsure of side effects that may have for this use case: https://github.com/golang/go/blob/master/src/net/http/server.go#L2034

See a PoC of this issue with this link: https://iris-go.com//google.com/

@wozz wozz requested a review from kataras as a code owner Apr 20, 2018

@CLAassistant

This comment has been minimized.

Copy link

commented Apr 20, 2018

CLA assistant check
All committers have signed the CLA.

@kataras

This comment has been minimized.

Copy link
Owner

commented Apr 21, 2018

Nice one @wozz! Thank you!

@kataras kataras merged commit 057a909 into kataras:master Apr 21, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.