Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with CoffeeScript #55

Closed
luketheobscure opened this issue Oct 18, 2016 · 10 comments
Labels
bug

Comments

@luketheobscure
Copy link
Contributor

@luketheobscure luketheobscure commented Oct 18, 2016

It looks like files compiled from CoffeeScript (using ember-cli-coffeescript) are not included when calculating code coverage. They don't show up on any of the reports.

@luketheobscure

This comment has been minimized.

Copy link
Contributor Author

@luketheobscure luketheobscure commented Nov 1, 2016

I've set up a demo app illustrating this bug: https://github.com/luketheobscure/ember-code-coverage-bug

I don't have the spare time to try to tackle this myself, but I would be happy to test things out.

@kategengler

This comment has been minimized.

Copy link
Owner

@kategengler kategengler commented Dec 22, 2016

I wonder if this isn't about coffeescript but is actually another manifestation of this bug #20

That issue was closed in version 0.3.6, could you see if using a newer version fixes this issue for you?

@luketheobscure

This comment has been minimized.

Copy link
Contributor Author

@luketheobscure luketheobscure commented Dec 22, 2016

I updated that demo app to 0.3.9, and it didn't fix the problem.

@luketheobscure

This comment has been minimized.

Copy link
Contributor Author

@luketheobscure luketheobscure commented Jun 7, 2017

Updated bug demo to use 0.3.12, still seeing the same issue. I would be happy to throw a little bit of time at this if you have any feedback on where to start.

Edit: Changing preprocessTree to postprocessTree at least insured that ember-cli-coffeescript was called first, but the files are never passed to CoverageInstrumenter.prototype.processString. Unfortunately I'm completely lost at debugging Broccoli, so that's as far as I got.

@turboladen

This comment has been minimized.

Copy link

@turboladen turboladen commented Jun 14, 2017

+1

@rwwagner90

This comment has been minimized.

Copy link
Collaborator

@rwwagner90 rwwagner90 commented Sep 27, 2017

@luketheobscure without knowing the exact issue, I think the before or after of ember-cli-coffeescript needs to be tweaked to allow the addons to run in the proper order https://github.com/kimroen/ember-cli-coffeescript/blob/master/package.json#L74-L81

@rwwagner90

This comment has been minimized.

Copy link
Collaborator

@rwwagner90 rwwagner90 commented Feb 13, 2018

Is there anyone using CoffeeScript that would like to test this out with the latest 1.0.0-beta.2?

@rwwagner90

This comment has been minimized.

Copy link
Collaborator

@rwwagner90 rwwagner90 commented Apr 24, 2018

@luketheobscure @turboladen can either of your please test this out with the latest beta, 1.0.0-beta.3?

@luketheobscure

This comment has been minimized.

Copy link
Contributor Author

@luketheobscure luketheobscure commented Apr 24, 2018

I'm afraid we migrated all of our projects off of CoffeeScript. https://github.com/decaffeinate/decaffeinate is incredible.

@rwwagner90 rwwagner90 added the bug label Aug 30, 2018
@rwwagner90

This comment has been minimized.

Copy link
Collaborator

@rwwagner90 rwwagner90 commented Aug 30, 2018

CoffeeScript works now, I've tested it on a project using it.

@rwwagner90 rwwagner90 closed this Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.