Attempts to deserialize payload from the coverage endpoint #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbieTheWagner
changed the title
rwjblue
reviewed
Sep 17, 2020
lib/templates/test-body-footer.html
Outdated
| @@ -47,6 +47,14 @@ | |||
| return; | |||
| } | |||
|
|
|||
| if (typeof data === 'string') { | |||
There was a problem hiding this comment.
I guess I still want to understand why data would be a string. 🤔
There was a problem hiding this comment.
@xcambar - Have you looked into this?
There was a problem hiding this comment.
Not thoroughly, but an initial look did not exclude that the behavior originates in istanbul-lib-coverage, unfortunately.
|
Needs a rebase now that #289 has landed... |
xcambar
force-pushed
the
attempt_deserialize_json
branch
from
e4d16d9
to
ddc8536
Compare
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #286
As discussed in #286, this PR restores the initial behavior that attempts to deserialize a stringified JSON.