New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There was a off-by-one in buffer for the onion address. #9

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@Freaken

Freaken commented Feb 8, 2013

The base32_onion function writes BASE32_ONIONLEN+1 bytes to the buffer, however the onion buffer only contains BASE32_ONIONLEN bytes.

@nikcub

This comment has been minimized.

Show comment
Hide comment
@nikcub

nikcub Nov 18, 2014

this needs to be merged, get lots of false positives without this patch

nikcub commented Nov 18, 2014

this needs to be merged, get lots of false positives without this patch

SleepProgger pushed a commit to SleepProgger/Shallot that referenced this pull request Nov 22, 2014

@herzi

This comment has been minimized.

Show comment
Hide comment
@herzi

herzi Jun 5, 2015

This bug happens to me as well.

I can verify that base32_onion() indeed needs a buffer with the size of BASE32_ONIONLEN + 1 (see src/print.c: The method will write to but[BASE32_ONIONLEN] in the end).

If you add me to the github collaborators for this repo, I'd love to take a look at this and other pull requests and merge them into this repository.

herzi commented Jun 5, 2015

This bug happens to me as well.

I can verify that base32_onion() indeed needs a buffer with the size of BASE32_ONIONLEN + 1 (see src/print.c: The method will write to but[BASE32_ONIONLEN] in the end).

If you add me to the github collaborators for this repo, I'd love to take a look at this and other pull requests and merge them into this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment