New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better figure links for captioned figures #205

Open
kaushalmodi opened this Issue Sep 7, 2018 · 3 comments

Comments

Projects
None yet
1 participant
@kaushalmodi
Copy link
Owner

kaushalmodi commented Sep 7, 2018

Ref: #204, #234

@kaushalmodi

This comment has been minimized.

Copy link
Owner Author

kaushalmodi commented Sep 7, 2018

This is gated by gohugoio/hugo#4406:

(caption (when (org-string-nw-p caption)
           (format "%s%s%s%s"
                   ;; Tue Feb 13 11:32:45 EST 2018 - kmodi
                   ;; Add the span tag once
                   ;; https://github.com/gohugoio/hugo/issues/4406
                   ;; gets resolved.
                   "" ;"<span class=\\\"figure-number\\\">"
                   (format (org-html--translate "Figure %d:" info)
                           (org-export-get-ordinal
                            useful-parent info
                            nil #'org-html--has-caption-p))
                   " "     ;" </span>"
                   ;; Escape the double-quotes, if any,
                   ;; present in the caption.
                   (replace-regexp-in-string "\"" "\\\\\"" caption))))

source

@kaushalmodi kaushalmodi added the upstream label Sep 7, 2018

@kaushalmodi

This comment has been minimized.

Copy link
Owner Author

kaushalmodi commented Sep 7, 2018

Related: #136.

@kaushalmodi

This comment has been minimized.

Copy link
Owner Author

kaushalmodi commented Oct 2, 2018

This issue can get fixed once gohugoio/hugo#5276 is merged.

@kaushalmodi kaushalmodi removed the upstream label Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment