New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for json data visualization #19

Merged
merged 4 commits into from Sep 13, 2018

Conversation

Projects
None yet
4 participants
@farhaanbukhsh
Collaborator

farhaanbukhsh commented Jun 23, 2018

This commit adds the script to support json data visualization,
this works on the fact that the data downloded is in JSON format.

This gives the trends like the most messages in which year, or which month of the year you text the most etc.

Signed-off-by: Farhaan Bukhsh farhaan.bukhsh@gmail.com

@techytushar

This comment has been minimized.

Collaborator

techytushar commented Jun 23, 2018

Few suggestion from my side:

  • Instead of asking for the exact location of message folder we should only ask for the location of the extracted folder, because the same schema is being followed in the plot_friends.py script.
  • If I don't give the location of the folder while running the script, then it gives an error, like if I run python messages_json_plot.py then it gives an error. Instead it should prompt user to input location of the folder.
  • Please add some sample data in the examples folder so that the user can run the scripts without his/her facebook data.
  • Please also add pandas to requirements.txt file.
  • Updation in the readme file might also be required.
@kaustubhhiware

This comment has been minimized.

Owner

kaustubhhiware commented Jun 24, 2018

I was thinking we should either have all scripts or all classes, not both. Need to standardise this.

Also, no need to make new file, just call this plot_messages.py.

Could you please add a sample json file like @techytushar did in his previous PR?

@farhaanbukhsh

This comment has been minimized.

Collaborator

farhaanbukhsh commented Jul 1, 2018

@kaustubhhiware I don't know I feel that if we write it in terms of classes there can be a lot of reusable code that can be seen, and also IMHO I feel it gives the code a structure but again it's your call. 😄

@techytushar Thanks for the feed back will try to include sample data but I feel it will be great to let them download and use their data.

@techytushar

i got this error while running the script
screenshot from 2018-07-16 03-58-08

@farhaanbukhsh

This comment has been minimized.

Collaborator

farhaanbukhsh commented Jul 17, 2018

Ahh my bad I should have put the message for message location

@farhaanbukhsh

This comment has been minimized.

Collaborator

farhaanbukhsh commented Jul 19, 2018

@techytushar can you try giving the location of the message folder?

@techytushar

This comment has been minimized.

Collaborator

techytushar commented Jul 19, 2018

@farhaanbukhsh Yes, now its working, but we should take the users facebook data folder address insted of message folder, as this is the convention going on in all other scripts. 🙂

@farhaanbukhsh

This comment has been minimized.

Collaborator

farhaanbukhsh commented Jul 20, 2018

@techytushar fixed it 😄 thanks a lot for suggestion, can @xprilion and @kaustubhhiware and @roopalJazz check it too?

farhaanbukhsh added some commits Jun 23, 2018

Add support for json data visualization
This commit adds the script to support json data visualization,
this works on the fact that the data downloded is in JSON format.

This gives the trends like the most messages in which year, or which month of the year you text the most etc.

Signed-off-by: Farhaan Bukhsh <farhaan.bukhsh@gmail.com>
Add requirements and renamed the file
This commit adds the requirement and rename the file for proper convention,
this also introduces the changes to make the location taken by user as well as
passed by the command line arguement.

Signed-off-by: Farhaan Bukhsh <farhaan.bukhsh@gmail.com>
Update readme and add dummy
This commit add dummy data as well as updated the read me for the project.

Signed-off-by: Farhaan Bukhsh <farhaan.bukhsh@gmail.com>
Add the message location to the extract folder
Signed-off-by: Farhaan Bukhsh <farhaan.bukhsh@gmail.com>
@farhaanbukhsh

This comment has been minimized.

Collaborator

farhaanbukhsh commented Sep 3, 2018

should I merge this in guys? 🤣 been real long?

@kaustubhhiware

Might as well

@farhaanbukhsh

This comment has been minimized.

Collaborator

farhaanbukhsh commented Sep 13, 2018

Merging this in 😄

@farhaanbukhsh farhaanbukhsh merged commit c0c1cfb into master Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment