fix: axe DevTools Critical Issues #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/kawamata-team/animated-emoji-gen/5ELnkXU2HSY6tnXbcu2PtV4L3CMy |
|
Thanks for the very nice pull request👍 |
kawamataryo
approved these changes
Aug 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Use to axe DevTools to resolve critical accessibility issues.
Images must have alternate text
Ensures
<img>elements have alternate text or a role of none or presentation.I've added alt attributes and alternative text to the icon image that links to the GitHub repository (ef847a6).
Form elements must have labels
Ensures every form element has a label.
No label was found for
<input type="color">. Since it is not visually presented in the current design, I created a hidden label using the visually-hidden technique (51b9340).Result