Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewards always zero #1

Open
nuomizai opened this issue Jan 10, 2024 · 0 comments
Open

rewards always zero #1

nuomizai opened this issue Jan 10, 2024 · 0 comments

Comments

@nuomizai
Copy link

Hi, @kaymen99 , thanks for your code. Is there anything wrong with the her_augmentation function under HER.py file where the re-computed reward is always zero?

reward = agent.env.compute_reward(future_achgoal, future_achgoal, 1.0)

And why should we take the future observation as the augmented observation, shouldn't we keep the observation in the current timestep, i.e., obs, _, _ = obs_array[index].values() as the augmented observation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant