Yuriy O'Donnell kayru

kayru commented on issue ocornut/imgui#129
@kayru

Thanks! I shall give it a spin later today.

kayru commented on issue ocornut/imgui#129
@kayru

Aha! Looks very nice :)

kayru deleted branch dbgeng_plugin at kayru/ProDBG
kayru pushed to master at emoon/ProDBG
@kayru
kayru merged pull request emoon/ProDBG#71
@kayru
Microsoft Debugger Engine plugin skeleton implementation
10 commits with 542 additions and 0 deletions
kayru opened pull request emoon/ProDBG#71
@kayru
Microsoft Debugger Engine plugin skeleton implementation
10 commits with 542 additions and 0 deletions
kayru commented on issue ocornut/imgui#129
@kayru

Thanks for taking time to look into this! :) The draft looks pretty much like what I'm after. Single selection vs no selection is a good point. Per…

kayru opened issue ocornut/imgui#129
@kayru
List boxes
@kayru
kayru pushed to master at kayru/dolphin
@kayru
kayru deleted branch stable at kayru/dolphin
kayru deleted branch d3d_efb_copy_fix at kayru/dolphin
@kayru
  • @kayru fca5c4c
    Register dbgeng_plugin with prodbg
@kayru
@kayru
  • @kayru 5688c27
    D3D: Moved setting texture by slot mask into StateManager
kayru commented on commit kayru/dolphin@dfbb871db1
@kayru

Fixed, thanks!

@kayru
  • @kayru 819f06d
    D3D: Moved setting texture by slot mask into StateManager
kayru commented on pull request dolphin-emu/dolphin#1689
@kayru

What's up with buildbot pr-deb* configs?

@kayru
  • @kayru dfbb871
    D3D: Moved setting texture by slot mask into StateManager
kayru commented on pull request dolphin-emu/dolphin#1689
@kayru

Do you mean add something like SetTextureByMask(textureSlotMask, texture) ?

kayru commented on pull request dolphin-emu/dolphin#1695
@kayru

Do you have a repro for that?

kayru commented on pull request dolphin-emu/dolphin#1695
@kayru

Agreed. This PR is kinda critical. I'm very surprised that it's not causing more severe issues in all games...

kayru commented on commit Armada651/dolphin@a2b43b21fe
@kayru

Should we set m_current.pixelShader here too, since we are sending it to d3d?

kayru commented on pull request dolphin-emu/dolphin#1503
@kayru

Good catch! Thanks @Armada651!

kayru commented on pull request dolphin-emu/dolphin#1695
@kayru

Dirty flags are there mainly to bypass larger sections of Apply(). We still do current!=pending check there. Perhaps we could remove some of those …

kayru commented on pull request dolphin-emu/dolphin#1695
@kayru

Yeah, I think that's a good idea!

kayru commented on commit Armada651/dolphin@07af5d6cb9
@kayru

I'm surprised it didn't cause massive issues in all sorts of games before.

kayru commented on commit Armada651/dolphin@07af5d6cb9
@kayru

I think you can just update your PR, since you found the bug & fix :)

kayru commented on commit Armada651/dolphin@07af5d6cb9
@kayru

Yup, you still update dirty flags when current != pending. If at any point between two Apply() calls you set a state that's not current, you set th…