New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable ignoring rules for comment setting. #8

Closed
tokuhirom opened this Issue Sep 27, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@tokuhirom
Contributor

tokuhirom commented Sep 27, 2017

DBIx::Sunny's comment setting system puts common internal classes as a comment.
For example, DBIx::Class uses Try::Tiny in query generation. As a result, when a user uses DBIx::Sunny with DBIx::Class, the user will use queries including /* local/lib/perl5/Try/Tiny.pm line 3 */.

In this line, DBIx::Sunny skips DBIx::* and DBD::* packages. In addition, DBIx::Sunny should support customizable package ignoring.
https://github.com/kazeburo/DBIx-Sunny/blob/master/lib/DBIx/Sunny.pm#L84

Carp.pm has a similar function. I suggest that you imitate the name from there and define a package variable named our %INTERNAL.

@tokuhirom

This comment has been minimized.

Show comment
Hide comment
@tokuhirom

tokuhirom Sep 27, 2017

Contributor

Just hard code to ignore Try::Tiny is OK.

Contributor

tokuhirom commented Sep 27, 2017

Just hard code to ignore Try::Tiny is OK.

@kazeburo kazeburo closed this in dd2e56d Sep 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment