Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to strict ByteString #59

Merged
merged 1 commit into from Jul 19, 2017

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Jul 3, 2017

DNS packets are small and there is little to no advantage of using
lazy ByteStrings.

DNS packets are small and there is little to no advantage of using
lazy ByteStrings.

Closes: kazu-yamamoto#58
@erikd
Copy link
Contributor Author

erikd commented Jul 18, 2017

Ping?

@kazu-yamamoto kazu-yamamoto self-requested a review July 19, 2017 00:26
Copy link
Owner

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kazu-yamamoto kazu-yamamoto merged commit 4b38aa7 into kazu-yamamoto:master Jul 19, 2017
@kazu-yamamoto
Copy link
Owner

Sorry for the delay. I did not notice this PR. Merged.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants