Consider adding picotest/picotest.[ch] to the release tarball #61

Closed
karya0 opened this Issue Dec 15, 2014 · 5 comments

Comments

Projects
None yet
2 participants
@karya0
Contributor

karya0 commented Dec 15, 2014

The 1.2.0 tarball doesn't have picotest/picotest.[ch] files causing 'make test' to fail with missing files error. Is there a possibility to do tag another release (1.2.1) with those files included in the tarball?

@kazuho

This comment has been minimized.

Show comment
Hide comment
@kazuho

kazuho Dec 15, 2014

Owner

Sorry for the issue. It seems that the tarball automatically created by GitHub does not include the contents of a submodule. Let me see how I should fix this.

Owner

kazuho commented Dec 15, 2014

Sorry for the issue. It seems that the tarball automatically created by GitHub does not include the contents of a submodule. Let me see how I should fix this.

@kazuho

This comment has been minimized.

Show comment
Hide comment
@kazuho

kazuho Dec 15, 2014

Owner

I googled for a solution, but could not find a way to create a custom source release using GitHub; it seems like that there is no way to configure how or replace the source release tarball.

@karya0 Do you see it as a requirement that there should be a test when building a distribution? Or is it just a suggestion?

If it is something required (or highly desirable) by somebody then I will run git clone if picotest/ is empty. If it is not, I might better wait until somebody (or GitHub) comes up with a better solution.

Note: aerospike/aerospike-client-c#6 discusses the same issue.

Owner

kazuho commented Dec 15, 2014

I googled for a solution, but could not find a way to create a custom source release using GitHub; it seems like that there is no way to configure how or replace the source release tarball.

@karya0 Do you see it as a requirement that there should be a test when building a distribution? Or is it just a suggestion?

If it is something required (or highly desirable) by somebody then I will run git clone if picotest/ is empty. If it is not, I might better wait until somebody (or GitHub) comes up with a better solution.

Note: aerospike/aerospike-client-c#6 discusses the same issue.

@karya0

This comment has been minimized.

Show comment
Hide comment
@karya0

karya0 Dec 15, 2014

Contributor

Basically, if someone downloads just the tarball, and runs make test after extracting it, it fails.

Running test suite (if available) when building a distribution package is recommended, but not a requirement. Basically, it helps us prevent broken packages by detecting the errors during the build step rather than later when someone uses it.

Having said that, don't worry too much about it. I will just test the release locally and create the distro packages without "make test".

In the meanwhile, should we keep this issue open until we find a better solution?

Contributor

karya0 commented Dec 15, 2014

Basically, if someone downloads just the tarball, and runs make test after extracting it, it fails.

Running test suite (if available) when building a distribution package is recommended, but not a requirement. Basically, it helps us prevent broken packages by detecting the errors during the build step rather than later when someone uses it.

Having said that, don't worry too much about it. I will just test the release locally and create the distro packages without "make test".

In the meanwhile, should we keep this issue open until we find a better solution?

@kazuho

This comment has been minimized.

Show comment
Hide comment
@kazuho

kazuho Dec 15, 2014

Owner

Thank you for the answer. Understood and agreed.

In the meanwhile, should we keep this issue open until we find a better solution?

👍

Owner

kazuho commented Dec 15, 2014

Thank you for the answer. Understood and agreed.

In the meanwhile, should we keep this issue open until we find a better solution?

👍

@kazuho kazuho closed this in faae614 Dec 16, 2014

@kazuho

This comment has been minimized.

Show comment
Hide comment
@kazuho

kazuho Dec 16, 2014

Owner

Switched to using git subtree to resolve the issue, and released v1.2.1.

Please reopen the issue if the problem persists.

Owner

kazuho commented Dec 16, 2014

Switched to using git subtree to resolve the issue, and released v1.2.1.

Please reopen the issue if the problem persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment