New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linked message translates the translated message #478

Closed
metalanti opened this Issue Dec 6, 2018 · 15 comments

Comments

Projects
None yet
6 participants
@metalanti
Copy link

metalanti commented Dec 6, 2018

vue & vue-i18n version

2.5.17, 8.4.0

I dont know if it is the expected behavior
the linked message translates the translated message

Reproduction

{
  "hello": "Hello {name}",
  "linkedHello": "@:hello"
}

<p>{{ $t('hello', { name: 'World {text}' }) }}</p> - good
<p>{{ $t('hello', { name: 'World {text}', text: 'something' }) }}</p> - good

<p>{{ $t('linkedHello', { name: 'World {text}' }) }}</p> - bad
<p>{{ $t('linkedHello', { name: 'World {text}', text: 'something' }) }}</p> - bad

What is Expected?

<p>Hello World {text}</p>

What is actually happening?

<p>Hello World {text}</p> - good
<p>Hello World {text}</p> - good

<p>Hello World </p> - bad
<p>Hello World something</p> - bad

@IssuehuntBot

This comment has been minimized.

Copy link

IssuehuntBot commented Dec 17, 2018

@kazupon has funded $30.00 to this issue. See it on IssueHunt

@kimuraz

This comment has been minimized.

Copy link
Contributor

kimuraz commented Dec 18, 2018

@kazupon may I get this one too? 😬

@kazupon

This comment has been minimized.

Copy link
Owner

kazupon commented Dec 18, 2018

@kimuraz
You can contribute :)

@IssuehuntBot

This comment has been minimized.

Copy link

IssuehuntBot commented Jan 5, 2019

@kazupon has funded $30.00 to this issue. See it on IssueHunt

@gurungrahul2

This comment has been minimized.

Copy link

gurungrahul2 commented Jan 6, 2019

No activity since 10 days, can I take it ?

@kazupon

This comment has been minimized.

Copy link
Owner

kazupon commented Jan 6, 2019

@kazupon

This comment has been minimized.

Copy link
Owner

kazupon commented Jan 6, 2019

@gurungrahul2
sorry, please wait.

@kimuraz
Are you still challenging this issue?

@kimuraz

This comment has been minimized.

Copy link
Contributor

kimuraz commented Jan 9, 2019

@kazupon
I actually made some changes, but I really couldn't keep going for a while, I think @gurungrahul2 can take it... sorry for bothering and for the late reply

@kazupon

This comment has been minimized.

Copy link
Owner

kazupon commented Jan 9, 2019

@kimuraz
Thank you for you contributing!
okay, no worry :)

@gurungrahul2
You can do it!

@gurungrahul2

This comment has been minimized.

Copy link

gurungrahul2 commented Jan 12, 2019

@kazupon how can I test if my changes fix the issue, how can i re-build vue with my changes and import to my web page ?

@kazupon

This comment has been minimized.

Copy link
Owner

kazupon commented Jan 15, 2019

@gurungrahul2
You can contribute by contribution guide.

@gurungrahul2

This comment has been minimized.

Copy link

gurungrahul2 commented Jan 19, 2019

@kazupon but it still doesn't answer my doubt.

@kimuraz

This comment has been minimized.

Copy link
Contributor

kimuraz commented Jan 20, 2019

@gurungrahul2 I migth have something on my old attempt...

kimuraz@e3c11c0

@exoego

This comment has been minimized.

Copy link
Contributor

exoego commented Jan 20, 2019

how can I test if my changes fix the issue

Refer development setup.
https://github.com/kazupon/vue-i18n/blob/dev/CONTRIBUTING.md#development-setup

It tells how to setup test environment and how to run tests.

how can i re-build vue with my changes and import to my web page ?

Do you mean: you want to test new changes added to vue-i18n (not vue) on your web page?

  1. npm run build
  2. Find the new vue-i18n.js built in dist directory.
  3. Upload it to your web page and test manually.

But you don't need to do so.
vue-i18n has end-2-end test which runs tests on web browser using Selenium.
If you add new tests (and maybe updating existing tests), Selenium runs tests on browsers automatically.

@kazupon kazupon closed this in 469edd9 Feb 10, 2019

@IssuehuntBot

This comment has been minimized.

Copy link

IssuehuntBot commented Feb 10, 2019

@kazupon has rewarded $42.00 to @stroncium. See it on IssueHunt

  • 💰 Total deposit: $60.00
  • 🎉 Repository reward(20%): $12.00
  • 🔧 Service fee(10%): $6.00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment