From d2afd98ad001653efa745cbdb4abe79173d18dad Mon Sep 17 00:00:00 2001 From: Hyukjin Kwon Date: Thu, 7 Apr 2022 09:44:10 +0900 Subject: [PATCH] Revert "[MINOR][SQL][SS][DOCS] Add varargs to Dataset.observe(String, ..) with a documentation fix" This reverts commit 72a0562f62eb66388ca3d2b2e2b17928124e8e69. --- sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala b/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala index c649d7582c955..fe84cc09e109a 100644 --- a/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala +++ b/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala @@ -1914,7 +1914,6 @@ class Dataset[T] private[sql]( * {{{ * // Monitor the metrics using a listener. * spark.streams.addListener(new StreamingQueryListener() { - * override def onQueryStarted(event: QueryStartedEvent): Unit = {} * override def onQueryProgress(event: QueryProgressEvent): Unit = { * event.progress.observedMetrics.asScala.get("my_event").foreach { row => * // Trigger if the number of errors exceeds 5 percent @@ -1926,7 +1925,8 @@ class Dataset[T] private[sql]( * } * } * } - * override def onQueryTerminated(event: QueryTerminatedEvent): Unit = {} + * def onQueryStarted(event: QueryStartedEvent): Unit = {} + * def onQueryTerminated(event: QueryTerminatedEvent): Unit = {} * }) * // Observe row count (rc) and error row count (erc) in the streaming Dataset * val observed_ds = ds.observe("my_event", count(lit(1)).as("rc"), count($"error").as("erc")) @@ -1936,7 +1936,6 @@ class Dataset[T] private[sql]( * @group typedrel * @since 3.0.0 */ - @varargs def observe(name: String, expr: Column, exprs: Column*): Dataset[T] = withTypedPlan { CollectMetrics(name, (expr +: exprs).map(_.named), logicalPlan) }