New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ugly code PR #10

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@kazy1991
Owner

kazy1991 commented May 14, 2017

No description provided.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot May 14, 2017

Codecov Report

Merging #10 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #10      +/-   ##
============================================
+ Coverage      90.9%   91.04%   +0.13%     
- Complexity       28       29       +1     
============================================
  Files             3        3              
  Lines            66       67       +1     
  Branches         11       11              
============================================
+ Hits             60       61       +1     
  Misses            3        3              
  Partials          3        3
Impacted Files Coverage Δ Complexity Δ
...ava/com/github/kazy1991/prefkit/ServiceMethod.java 89.74% <100%> (+0.26%) 16 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd24fa...2c3f28a. Read the comment docs.

codecov bot commented May 14, 2017

Codecov Report

Merging #10 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #10      +/-   ##
============================================
+ Coverage      90.9%   91.04%   +0.13%     
- Complexity       28       29       +1     
============================================
  Files             3        3              
  Lines            66       67       +1     
  Branches         11       11              
============================================
+ Hits             60       61       +1     
  Misses            3        3              
  Partials          3        3
Impacted Files Coverage Δ Complexity Δ
...ava/com/github/kazy1991/prefkit/ServiceMethod.java 89.74% <100%> (+0.26%) 16 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd24fa...2c3f28a. Read the comment docs.

@@ -18,6 +18,8 @@
private PreferenceHelper helper;
public static final List<Locale> SUPPORT_LANG = Arrays.asList(Locale.JAPANESE, Locale.ENGLISH);

This comment has been minimized.

@kazybot

kazybot May 14, 2017

⚠️ com.github.kazy1991.prefkit.ServiceMethod.SUPPORT_LANG is a mutable collection which should be package protected
@kazybot

kazybot May 14, 2017

⚠️ com.github.kazy1991.prefkit.ServiceMethod.SUPPORT_LANG is a mutable collection which should be package protected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment