- Added all requested RTL features. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AndreYonadam
commented
Jan 18, 2017
AndreYonadam
commented
- Can now specify the initial text direction.
- Dynamically handles changes in text direction when the textarea's direction is changed by the browser. Changes are reflected by the placeholder element as well.
added 4 commits
January 17, 2017 19:47
- Added initial RTL setting
- Switched from text-align to dir attribute because its safer to use since the user can change the dir property easily through the browser by right clicking and changing the direction of the paragraph text.
…e browser. - Now also updates if the user changes the texture's direction via the browser.
|
It seems there are some bugs when trying to write code on RTL-enabled editor. Here is a sample:
No idea if this is a browser bug or just some missing CSS/JS property for dealing with RTL texts. |
|
Just as a heads up. I don't think this is an issue with the CodeFlask editor. I tested the actual comment section here and it has the same effect when in the right-to-left mode. Maybe we must test an RTL language? I'm not sure. |
|
It seems @MajidCS tested it with a RTL language and everything worked as expected (see #26), so I'm merging the PR. As always, thanks for the incredible work @AndreYonadam! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.