Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
No cython to install #20
This is a start for #18 -- I believe it removes Cython as a requirement to install. I just checked, and it seems like NumPy does NOT need to be pre-installed to compile.
I am working on including the NumPy implementation in #19, but I am not sure how to test setup without the compiler. I tried installing without NumPy or Cython pre-installed. After pip installed the NumPy requirement, it seemed to go back to compile the .c file.
ixjlyons left a comment
This looks good to me.
As long as the C file is included in the
Maybe go ahead with this PR and work on the numpy-only related packaging over in the other PR or a separate one?
Turns out we don't need to override the sdist command at all (anymore?).
In my environment (python 3.6) with Cython installed, I can run
So with #19, this should be pip installable now?
Should we add the .c file to the repository so that you could install from the repository without Cython? Or say that if you are installing from the repository, you have to use Cython? Leaning towards the latter.
I'm not sure why, but when I try to install from PyPI my compiler complains about not finding the header file. Could you try? Use
to pull ndsplines from test and numpy/scipy from production
I was just looking at that. It looks like I can add the .h file to the second argument and it seems to work. I am not sure why I can't find a docs for the Extension class.
Do you mind trying again?
Uploading, after installing twine, is:
.. code:: bash