Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding tests #41

Merged
merged 33 commits into from Aug 19, 2019

Conversation

@sixpearls
Copy link
Collaborator

commented Aug 1, 2019

Ongoing test development to address #5

sixpearls added some commits Aug 1, 2019

removing bc argument from make_interp_spline; adding knot utility fun…
…ctions, but not sure if actually useful

@sixpearls sixpearls force-pushed the add-tests branch from f7e8dbd to 9305552 Aug 15, 2019

@ixjlyons

This comment has been minimized.

Copy link
Member

commented Aug 17, 2019

Commit 3dfbce6 is somehow causing segfaults on all platforms: https://dev.azure.com/kb-press/ndsplines/_build/results?buildId=76

Bug in numpy?

@sixpearls

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 17, 2019

Thanks for figuring out why 3dfbce6 was broken. f79737f actually ran completely fine on my machine (Windows, Python 3.6).

sixpearls added some commits Aug 17, 2019

@sixpearls

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 19, 2019

@ixjlyons Can you get logs to determine which tests are failing? They all ran fine on my machine.
Actually, I may need to indicate pandas is a test requirement now....

After the build issue is resolved, I will declare the test writing done. Do you want to add a badge to this branch or another? Or should I set it up?

sixpearls added some commits Aug 19, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Aug 19, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@f8153fa). Click here to learn what that means.
The diff coverage is 77.14%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #41   +/-   ##
=========================================
  Coverage          ?   36.24%           
=========================================
  Files             ?       10           
  Lines             ?      745           
  Branches          ?        0           
=========================================
  Hits              ?      270           
  Misses            ?      475           
  Partials          ?        0
Impacted Files Coverage Δ
ndsplines/ndsplines.py 0% <0%> (ø)
tests/test_ndsplines.py 100% <100%> (ø)
tests/test_eval.py 100% <100%> (ø)
tests/test_make_interp.py 100% <100%> (ø)
tests/test_make_lsq.py 68.33% <68.33%> (ø)
tests/utils.py 97.14% <97.14%> (ø)
tests/test_calculus.py 97.29% <97.29%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8153fa...f28ecea. Read the comment docs.

sixpearls added some commits Aug 19, 2019

@sixpearls sixpearls merged commit fb7ab4f into master Aug 19, 2019

7 checks passed

kb-press.ndsplines Build #20190819.11 succeeded
Details
kb-press.ndsplines (Job Linux_Py36) Job Linux_Py36 succeeded
Details
kb-press.ndsplines (Job Linux_Py37) Job Linux_Py37 succeeded
Details
kb-press.ndsplines (Job Mac_Py36) Job Mac_Py36 succeeded
Details
kb-press.ndsplines (Job Mac_Py37) Job Mac_Py37 succeeded
Details
kb-press.ndsplines (Job Windows_Py36) Job Windows_Py36 succeeded
Details
kb-press.ndsplines (Job Windows_Py37) Job Windows_Py37 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.