From 65e7ef6fbcb8df79c41dbcf0a7d0a5dd8e99321c Mon Sep 17 00:00:00 2001 From: Erik Pearson Date: Wed, 13 Jun 2018 06:33:28 -0700 Subject: [PATCH 1/3] dataview: prevent breaking tables in header area [SCT-1038] --- config/app/dev/plugins.yml | 2 +- config/app/prod/plugins.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/config/app/dev/plugins.yml b/config/app/dev/plugins.yml index 7a33f43f2..84e6f2cb4 100644 --- a/config/app/dev/plugins.yml +++ b/config/app/dev/plugins.yml @@ -33,7 +33,7 @@ plugins: - name: dataview globalName: kbase-ui-plugin-dataview - version: 3.8.0 + version: 3.8.2 cwd: src/plugin source: bower: {} diff --git a/config/app/prod/plugins.yml b/config/app/prod/plugins.yml index f3db09442..a3535b528 100644 --- a/config/app/prod/plugins.yml +++ b/config/app/prod/plugins.yml @@ -33,7 +33,7 @@ plugins: - name: dataview globalName: kbase-ui-plugin-dataview - version: 3.8.0 + version: 3.8.2 cwd: src/plugin source: bower: {} From b76c7c5b25423c23c574356b310fa8cd585d62eb Mon Sep 17 00:00:00 2001 From: Erik Pearson Date: Wed, 13 Jun 2018 06:34:10 -0700 Subject: [PATCH 2/3] prevent breaking page title [SCT-1075] --- src/plugins/mainwindow/modules/mainWindow.css | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/plugins/mainwindow/modules/mainWindow.css b/src/plugins/mainwindow/modules/mainWindow.css index ef4717d73..974052674 100644 --- a/src/plugins/mainwindow/modules/mainWindow.css +++ b/src/plugins/mainwindow/modules/mainWindow.css @@ -111,6 +111,10 @@ align-items: center; justify-content: left; display: flex; + width: 0px; + overflow-x: hidden; + white-space: nowrap; + text-overflow: ellipsis; } .plugin-mainwindow.widget-mainwindow .-navbar .-cell.-menu {} From b06ac6e96f87ce444e9e13ae55bf7e5bd29121b7 Mon Sep 17 00:00:00 2001 From: Erik Pearson Date: Wed, 13 Jun 2018 06:34:28 -0700 Subject: [PATCH 3/3] behave better when service down [SCT-1075] --- bower.json | 2 +- src/client/modules/lib/kbaseServiceManager.js | 12 ++++++++++-- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/bower.json b/bower.json index 0e9cff0ed..1d6ed52a5 100644 --- a/bower.json +++ b/bower.json @@ -37,7 +37,7 @@ "kbase-knockout-extensions-es6": "0.1.4", "kbase-common-ts": "0.18.0", "kbase-common-js": "2.16.1", - "kbase-common-es6": "0.5.1", + "kbase-common-es6": "0.5.2", "kbase-sdk-clients-js": "0.5.1", "kbase-service-clients-js": "3.3.5", "kbase-ui-widget": "1.3.0", diff --git a/src/client/modules/lib/kbaseServiceManager.js b/src/client/modules/lib/kbaseServiceManager.js index 75464bef5..447e2b672 100644 --- a/src/client/modules/lib/kbaseServiceManager.js +++ b/src/client/modules/lib/kbaseServiceManager.js @@ -49,8 +49,8 @@ define([ throw new Error(errorMessage); } else { console.error(errorMessage); + return null; } - }); } @@ -70,6 +70,7 @@ define([ throw new Error(errorMessage); } else { console.error(errorMessage); + return null; } }); } @@ -89,11 +90,18 @@ define([ throw new Error(errorMessage); } else { console.error(errorMessage); + return null; } } }).then((result) => { let version; - if (serviceConfig.version.propertyPath) { + if (result === null) { + if (!this.throwErrors) { + return null; + } else { + throw new Error('Invalid semver check result: ' + result); + } + } else if (serviceConfig.version.propertyPath) { version = props.getProp(result, serviceConfig.version.propertyPath); } else { version = result;