Service client update, ensuing ui and plugin adjustments #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deploy-sensitive, added "resources" top level property in services yaml template to catch them
eapearson
added a commit
that referenced
this pull request
Feb 11, 2016
Service client update, ensuing ui and plugin adjustments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A long overdue patch to the service clients to remove any default endpoint urls.
In the aftermath, several fixes were required for cases in which a bad config key was revealed (had been working because of the default url in the service client), as well as remaining hard coded urls within code, replaced by config calls.
Additional code cleanup as well.