Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix problem with showing subfolders in staging area #1208

Merged
merged 10 commits into from
Nov 17, 2017

Conversation

briehl
Copy link
Member

@briehl briehl commented Nov 9, 2017

not ready to merge yet - still need to get the metadata dropdown working in subfolders.
Also fixes problem with searching in the new dynamic dropdown input.

Edit: work's done, working on some kind of tests. But ready to review.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.5%) to 12.309% when pulling 1208b32 on briehl:import-refactor into bdbb7b6 on kbase:develop.

@briehl briehl changed the title [WIP] fix problem with showing subfolders in staging area fix problem with showing subfolders in staging area Nov 9, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+4.5%) to 12.309% when pulling 8b74212 on briehl:import-refactor into bdbb7b6 on kbase:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.6%) to 12.455% when pulling 436a3c8 on briehl:import-refactor into bdbb7b6 on kbase:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.6%) to 12.455% when pulling fd8ad88 on briehl:import-refactor into bdbb7b6 on kbase:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.6%) to 12.455% when pulling fd8ad88 on briehl:import-refactor into bdbb7b6 on kbase:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.6%) to 12.455% when pulling 1ae34d4 on briehl:import-refactor into bdbb7b6 on kbase:develop.

@briehl
Copy link
Member Author

briehl commented Nov 16, 2017

@thomasoniii I was working on this anyway since I was blocked by similar problems. I think I have that fixed. Mind taking a look?

@coveralls
Copy link

Coverage Status

Coverage increased (+4.6%) to 12.454% when pulling 016b741 on briehl:import-refactor into bdbb7b6 on kbase:develop.

@briehl
Copy link
Member Author

briehl commented Nov 16, 2017

Could use some more tests, but the import dropdown widget should be mostly done.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.6%) to 12.453% when pulling 0458fe6 on briehl:import-refactor into bdbb7b6 on kbase:develop.

Copy link
Contributor

@thomasoniii thomasoniii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. Let's get it integrated so I can pull it down into my changes and get it all nicely integrated.

@thomasoniii thomasoniii merged commit 9e21318 into kbase:develop Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants