From dcc1501a537b6e04a9164c497ff4a568d911734b Mon Sep 17 00:00:00 2001 From: JamesJeffryes Date: Wed, 3 Jan 2018 14:59:07 -0600 Subject: [PATCH 1/3] don't break if enzymes are missing --- .../function_output/modeling/KBaseFBA.FBAModel.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/kbase-extension/static/kbase/js/widgets/function_output/modeling/KBaseFBA.FBAModel.js b/kbase-extension/static/kbase/js/widgets/function_output/modeling/KBaseFBA.FBAModel.js index 9f64be8a91..a9faeacca6 100644 --- a/kbase-extension/static/kbase/js/widgets/function_output/modeling/KBaseFBA.FBAModel.js +++ b/kbase-extension/static/kbase/js/widgets/function_output/modeling/KBaseFBA.FBAModel.js @@ -242,6 +242,7 @@ function KBaseFBA_FBAModel(modeltabs) { this.ReactionTab = function (info) { var rxn = self.rxnhash[info.id]; + console.log(rxn) var output = [{ "label": "Reaction", "data": rxn.dispid, @@ -283,10 +284,12 @@ function KBaseFBA_FBAModel(modeltabs) { "data": data[0].deltaG+" ("+data[0].deltaGErr+") kcal/mol" }); } - output.push({ - "label": "Enzymes", - "data": data[0].enzymes.join(", ") - }); + if ("enzymes" in data[0]) { + output.push({ + "label": "Enzymes", + "data": data[0].enzymes.join(", ") + }); + } var aliashash = {}; var finalaliases = []; for (var i=0; i < data[0].aliases.length; i++) { From 0fafd91292a25294cc8104ee0bc67c5b0b26274d Mon Sep 17 00:00:00 2001 From: JamesJeffryes Date: Sat, 13 Jan 2018 17:33:08 -0600 Subject: [PATCH 2/3] SCT-156: Reactions in metabolic models link to their respective compound pages --- .../js/widgets/function_output/modeling/KBaseFBA.FBAModel.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kbase-extension/static/kbase/js/widgets/function_output/modeling/KBaseFBA.FBAModel.js b/kbase-extension/static/kbase/js/widgets/function_output/modeling/KBaseFBA.FBAModel.js index a9faeacca6..ff31ec487a 100644 --- a/kbase-extension/static/kbase/js/widgets/function_output/modeling/KBaseFBA.FBAModel.js +++ b/kbase-extension/static/kbase/js/widgets/function_output/modeling/KBaseFBA.FBAModel.js @@ -591,7 +591,7 @@ function KBaseFBA_FBAModel(modeltabs) { var abscoef = Math.round(-1*100*rgt.coefficient)/100; reactants += "("+abscoef+") "; } - reactants += this.cpdhash[rgt.cpdkbid].name+"["+this.cpdhash[rgt.cpdkbid].cmpkbid+"]"; + reactants += ''+this.cpdhash[rgt.cpdkbid].name+"["+this.cpdhash[rgt.cpdkbid].cmpkbid+"]"; } else { if (products.length > 0) { products += " + "; @@ -600,7 +600,7 @@ function KBaseFBA_FBAModel(modeltabs) { var abscoef = Math.round(100*rgt.coefficient)/100; products += "("+abscoef+") "; } - products += this.cpdhash[rgt.cpdkbid].name+"["+this.cpdhash[rgt.cpdkbid].cmpkbid+"]"; + products += ''+this.cpdhash[rgt.cpdkbid].name+"["+this.cpdhash[rgt.cpdkbid].cmpkbid+"]"; } } rxn.ftrhash = {}; From 7001467e1593299b570e2f6e9926ad2f4df728ee Mon Sep 17 00:00:00 2001 From: James Jeffryes Date: Thu, 25 Jan 2018 07:16:57 -0600 Subject: [PATCH 3/3] remove extra logging --- .../js/widgets/function_output/modeling/KBaseFBA.FBAModel.js | 1 - 1 file changed, 1 deletion(-) diff --git a/kbase-extension/static/kbase/js/widgets/function_output/modeling/KBaseFBA.FBAModel.js b/kbase-extension/static/kbase/js/widgets/function_output/modeling/KBaseFBA.FBAModel.js index ff31ec487a..ce843b332b 100644 --- a/kbase-extension/static/kbase/js/widgets/function_output/modeling/KBaseFBA.FBAModel.js +++ b/kbase-extension/static/kbase/js/widgets/function_output/modeling/KBaseFBA.FBAModel.js @@ -242,7 +242,6 @@ function KBaseFBA_FBAModel(modeltabs) { this.ReactionTab = function (info) { var rxn = self.rxnhash[info.id]; - console.log(rxn) var output = [{ "label": "Reaction", "data": rxn.dispid,