Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running BrowserFetcher().DownloadAsync on Raspberry Pi downloads x64 version instead of ARM #1181

Closed
rgelb opened this issue Jun 21, 2019 · 3 comments
Labels
Upstream Change needed We need to wait for changes in Chromium or Puppeteer (Node.JS)

Comments

@rgelb
Copy link
Contributor

rgelb commented Jun 21, 2019

Description

Running BrowserFetcher().DownloadAsync on Raspberry Pi downloads x64 version instead of ARM.

Complete minimal example reproducing the issue

await new BrowserFetcher().DownloadAsync(BrowserFetcher.DefaultRevision);

Expected behavior:

Compatible ARM build downloads.

Actual behavior:

X64 Linux build downloads.

Versions

  • PuppetSharp 1.17.2
  • .NET Core 2.2

Additional Information

The workaround is to sudo apt-get install chromium-browser and then

var options = new LaunchOptions() {
            ExecutablePath = "/usr/bin/chromium-browser",
            Headless = true
};
var browser = await Puppeteer.LaunchAsync(options);
@kblok kblok added the feature label Jun 24, 2019
@kblok
Copy link
Member

kblok commented Jul 17, 2019

There are some recipes here puppeteer/puppeteer#550
Puppeteer is not downloading a chrome version for ARM.

@kblok kblok closed this as completed Jul 17, 2019
@kblok kblok added Upstream Change needed We need to wait for changes in Chromium or Puppeteer (Node.JS) and removed feature labels Jul 17, 2019
@aengl
Copy link

aengl commented Oct 30, 2019

Is that an unwanted feature?

I had a look at https://github.com/GoogleChrome/puppeteer/blob/master/lib/BrowserFetcher.js which could easily be expanded to handle ARM. The only question is whether there is an ARM binary on https://storage.googleapis.com/chromium-browser-snapshots/index.html, which is a bit of a mess to navigate.

If there's interest I can look into creating a PR.

@kblok
Copy link
Member

kblok commented Oct 30, 2019

@aengl yeah you could create an issue there. The main question is if they are building ARM binaries for every revision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Upstream Change needed We need to wait for changes in Chromium or Puppeteer (Node.JS)
Projects
None yet
Development

No branches or pull requests

3 participants