Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Puppeteer abstractions #1073

Draft
wants to merge 10 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@Meir017
Copy link
Collaborator

commented Apr 16, 2019

Closes #1049

Meir017 added some commits Apr 16, 2019

wip
@kblok

This comment has been minimized.

Copy link
Owner

commented Apr 16, 2019

What I was thinking, even before taking a look at your PR, is that the rule number #1 should be not breaking existing code.
So, for instance, the class BoundingBox (to mention any). I would move that class to abstractions,
but I would leave one class in the same namespace marking it as obsolete and inheriting from the abstraction class. We could remove it in the next iteration.
The same for the interfaces. We need to implement explicit interfaces. So. for instance,
IBrowser.NewPageAsync returns IPage. but if I'm currently using Browser.NewPage I would still get a Page.
Not breaking existing code base is priority number 1.

@Meir017

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 16, 2019

@kblok so a good indicator will be that the tests project should not change at all?

@kblok

This comment has been minimized.

Copy link
Owner

commented Apr 16, 2019

@Meir017 exactly.

Meir017 added some commits Apr 17, 2019

wip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.