Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft Edge Friendly tests #1074

Merged
merged 3 commits into from Apr 22, 2019

Conversation

Projects
None yet
2 participants
@kblok
Copy link
Owner

commented Apr 19, 2019

We made some minor changes to our tests so they run with Microsoft Edge:

Microsoft Edge Friendly tests
We made some minor changes to our tests so they run with Microsoft Edge:
 * Intervention header has the URL https://to-be-replaced.invalid/feature/5718547946799104 instead of https://www.chromestatus.com/feature/5718547946799104. We are changing the "Contains" part
 * We are removing some new lines and using Trim to compare TextAsync
 * Edge launches two pages with default arguments. We are going to check that  the pages array is not empty.
@Meir017

This comment has been minimized.

Copy link
Collaborator

commented Apr 19, 2019

  • Edge launches two pages with default arguments. We are going to check that the pages array is not empty.

@kblok did the puppeteer project make these changes as well?

@kblok

This comment has been minimized.

Copy link
Owner Author

commented Apr 19, 2019

@Meir017 No. Do you think I should add some comments as a reference?
Chrome by default opens with one tab, whereas Edge opens with two.

@Meir017

This comment has been minimized.

Copy link
Collaborator

commented Apr 19, 2019

I think a comment should be enough.
maybe also open a pull-request on puppeteer with this change? 😉

@kblok

This comment has been minimized.

Copy link
Owner Author

commented Apr 19, 2019

@Meir017 both are great ideas.

@kblok

This comment has been minimized.

Copy link
Owner Author

commented Apr 19, 2019

Comment added @Meir017

@kblok kblok merged commit fbdabce into master Apr 22, 2019

3 checks passed

CodeFactor No issues found.
Details
Core + Net Framework AppVeyor build succeeded
Details
Linux AppVeyor build succeeded
Details

@kblok kblok deleted the v1.15/ms-edge-friendly-tests branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.