New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set headless option to false when Devtools are enabled #831

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@henkmollema
Copy link
Contributor

henkmollema commented Jan 2, 2019

The comments say the headless option will be set false:

/// <summary>
/// Whether to auto-open DevTools panel for each tab. If this option is true, the headless option will be set false.
/// </summary>
public bool Devtools { get; set; }

However, the headless option was not actually set to false.

@kblok kblok merged commit 82a9b33 into kblok:master Jan 3, 2019

3 checks passed

CodeFactor No issues found.
Details
Core + Net Framework AppVeyor build succeeded
Details
Linux AppVeyor build succeeded
Details

@henkmollema henkmollema deleted the henkmollema:devtools-headless-options branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment