Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Great Work! #235

Closed
vitaly-t opened this issue Jul 27, 2018 · 7 comments
Closed

Great Work! #235

vitaly-t opened this issue Jul 27, 2018 · 7 comments

Comments

@vitaly-t
Copy link

vitaly-t commented Jul 27, 2018

This is a very interesting solution, though I feel robbed - it promised a 3Kb after compression, and it's actually whole 8kb 😄

I found this library while having started on my own version of a mini-DOM framework. No worries, it is very different from what you do here , I'm just looking to steal some ideas for running tests 😄

@kbrsh
Copy link
Owner

kbrsh commented Jul 27, 2018

Thanks! It’s actually 3kb minified and gzipped. I’m still working on tests for the beta since there are still a couple of changes I need to make.

@vitaly-t
Copy link
Author

I know, I was just joking :) I'm working hard on my framework too, only I got stuck trying with automated tests, trying to find a good way to test DOM modifications. Tests sometimes can be a real bummer.

@vitaly-t
Copy link
Author

vitaly-t commented Jul 27, 2018

It would be nice to share some experience writing things like that ;) Just so, once again, yours is a mini UI framework, while mine is a mini DOM manipulator, so quite different things ;)

By any chance did you come across any issues exporting the library's root interface? Or did you use the current approach from the beginning? I'm using the stupid window for now, which has issues in the IE, and wonder what should be a better way...

@kbrsh
Copy link
Owner

kbrsh commented Jul 27, 2018

I used the current approach — it’s very popular and is used in many other libraries. I’d recommend using Rollup to package your library and check out the various output options that export to different environments automatically.

@vitaly-t
Copy link
Author

vitaly-t commented Jul 27, 2018

Thank you for the suggestions! 😄 I'm not sure if I will use the Rollup yet, since my library is even smaller than yours, and currently sits in just one single file.

And I was able to sort out the IE-related issues related to global variables. I found out the hard way that if you include a script as <script src="../src">, only IE failed to load the default index.js, it requires the full <script src="../src/index.js">, dumb browser! 😄

@kbrsh
Copy link
Owner

kbrsh commented Jul 27, 2018

Haha IE can be a hassle ;)

Let's continue this discussion over email (available on my site) as I don't want to use issues for discussions like these.

@kbrsh kbrsh closed this as completed Jul 27, 2018
@vitaly-t
Copy link
Author

vitaly-t commented Jul 30, 2018

@kbrsh Yep, thank you! I have also added chat to the project, and I appreciate if you offer an opinion and/or help with anything. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants