From 54352dcd3b62dc68ebefc90fb57c38f2c5a45fab Mon Sep 17 00:00:00 2001 From: "Nazarov, Rodion" Date: Thu, 7 Sep 2023 16:08:37 +0200 Subject: [PATCH] [Fix] Fix failing tests due to a missing class by adding new dependency. Use assertIsomorphic in tests instead of a non-emptiness check. --- s-pipes-modules/module-tabular/pom.xml | 5 + .../spipes/modules/TabularModuleTest.java | 14 ++- .../src/test/resources/countries_model.ttl | 117 ++++++++++++++++++ 3 files changed, 132 insertions(+), 4 deletions(-) create mode 100644 s-pipes-modules/module-tabular/src/test/resources/countries_model.ttl diff --git a/s-pipes-modules/module-tabular/pom.xml b/s-pipes-modules/module-tabular/pom.xml index 415475ed..cd7e29d8 100644 --- a/s-pipes-modules/module-tabular/pom.xml +++ b/s-pipes-modules/module-tabular/pom.xml @@ -62,6 +62,11 @@ cz.cvut.kbss s-pipes-core + + commons-codec + commons-codec + 1.15 + org.junit.jupiter junit-jupiter-api diff --git a/s-pipes-modules/module-tabular/src/test/java/cz/cvut/spipes/modules/TabularModuleTest.java b/s-pipes-modules/module-tabular/src/test/java/cz/cvut/spipes/modules/TabularModuleTest.java index bb218f07..c55a1454 100644 --- a/s-pipes-modules/module-tabular/src/test/java/cz/cvut/spipes/modules/TabularModuleTest.java +++ b/s-pipes-modules/module-tabular/src/test/java/cz/cvut/spipes/modules/TabularModuleTest.java @@ -10,7 +10,10 @@ import cz.cvut.spipes.test.JenaTestUtils; import cz.cvut.spipes.util.StreamResourceUtils; import org.apache.jena.rdf.model.*; -import org.junit.jupiter.api.*; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Disabled; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.provider.ValueSource; import org.slf4j.Logger; @@ -57,8 +60,9 @@ void executeWithSimpleTransformation() throws URISyntaxException, IOException { ); ExecutionContext outputContext = module.executeSelf(); + Model expectedModel = ModelFactory.createDefaultModel().read(getFilePath("countries_model.ttl").toString()); - assertTrue(outputContext.getDefaultModel().size() > 0); + assertIsomorphic(outputContext.getDefaultModel(),expectedModel); } @Test @@ -69,11 +73,13 @@ void executeWithSimpleTransformationXls() throws URISyntaxException, IOException getFilePath("countries.xls")) ); module.setSourceResourceFormat(ResourceFormat.EXCEL); - module.setProcessSpecificSheetInXLSFile(2); + module.setProcessSpecificSheetInXLSFile(1); ExecutionContext outputContext = module.executeSelf(); - assertTrue(outputContext.getDefaultModel().size() > 0); + Model expectedModel = ModelFactory.createDefaultModel().read(getFilePath("countries_model.ttl").toString()); + + assertIsomorphic(outputContext.getDefaultModel(),expectedModel); } @Test diff --git a/s-pipes-modules/module-tabular/src/test/resources/countries_model.ttl b/s-pipes-modules/module-tabular/src/test/resources/countries_model.ttl new file mode 100644 index 00000000..3f1f3e85 --- /dev/null +++ b/s-pipes-modules/module-tabular/src/test/resources/countries_model.ttl @@ -0,0 +1,117 @@ + + + "AD" ; + + "42.5" ; + + "1.6" ; + + "Andorra" . + + + + "AE" ; + + "23.4" ; + + "53.8" ; + + "United Arab Emirates" . + + + + "AF" ; + + "33.9" ; + + "67.7" ; + + "Afghanistan" . + +_:b0 a ; + + "name" ; + + "http://onto.fel.cvut.cz/data/name" ; + + "name" ; + + . + +_:b1 a ; + + "longitude" ; + + "http://onto.fel.cvut.cz/data/longitude" ; + + "longitude" ; + + . + +_:b2 a ; + + "countryCode" ; + + "http://onto.fel.cvut.cz/data/countryCode" ; + + "countryCode" ; + + . + +_:b3 a ; + + "latitude" ; + + "http://onto.fel.cvut.cz/data/latitude" ; + + "latitude" ; + + . + +[ a ; + + [ a ; + + [ a ; + + ; + + "3"^^ ; + + + ] ; + + [ a ; + + ; + + "1"^^ ; + + + ] ; + + [ a ; + + ; + + "2"^^ ; + + + ] ; + + [ a ; + + "http://test-file#row-{_row}"^^ ; + + _:b1 , _:b3 , _:b0 , _:b2 ; + + ( _:b2 + _:b3 + _:b1 + _:b0 + ) + ] ; + + + ] +] . \ No newline at end of file