Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser build #6

Closed
nullpilot opened this issue Jan 14, 2020 · 3 comments
Closed

Browser build #6

nullpilot opened this issue Jan 14, 2020 · 3 comments
Labels

Comments

@nullpilot
Copy link

@nullpilot nullpilot commented Jan 14, 2020

Using the lib in the browser didn't seem to be an option yet so I put together a quick build to get it working with JSDelivr for now. Maybe that can be leveraged as a starting point.

@kchapelier

This comment has been minimized.

Copy link
Owner

@kchapelier kchapelier commented Jan 14, 2020

As stated in the PR, thanks for your input, having a browser build directly in the repo would indeed be useful. However I'd rather have a browserify-based build process as I'm more confortable with this tool and it is much leaner. I'll tend to it later this week. Sorry for the time you spent on this, I consider it my failing for not providing contribution guidelines...

@nullpilot

This comment has been minimized.

Copy link
Author

@nullpilot nullpilot commented Jan 14, 2020

No problem at all. I specifically created the issue to get the conversation started. The PR was more of a show and tell to go along with that

@kchapelier

This comment has been minimized.

Copy link
Owner

@kchapelier kchapelier commented Jan 17, 2020

Browser builds have been added to the repo and the readme been updated with instructions on how to use CDNs to load the library. This should significantly ease the use of the library in the browser without requiring the user to setup a build process on his/her end. I made sure the CDN are serving the files correctly with a quick test on Codepen, so everything should be alright but let me know if something is amiss.

@kchapelier kchapelier closed this Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.