Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser build #7

Closed
wants to merge 3 commits into from
Closed

Conversation

@nullpilot
Copy link

nullpilot commented Jan 14, 2020

See #6

Demo

@redblobgames

This comment has been minimized.

Copy link

redblobgames commented Jan 14, 2020

Cool. I had tried https://unpkg.com/poisson-disk-sampling@1 but it didn't work.

@nullpilot

This comment has been minimized.

Copy link
Author

nullpilot commented Jan 14, 2020

The normal one doesn't work because of the require() calls, which is the problem I ran into when trying to use it. Is the minified script an unpkg feature, or is it part of the published package?

@kchapelier

This comment has been minimized.

Copy link
Owner

kchapelier commented Jan 14, 2020

@nullpilot Thanks for your input, having a browser build directly in the repo would indeed be useful. However I'd rather have a browserify-based build process as I'm more confortable with this tool and it is much leaner. I'll tend to it later this week. Sorry for the time you spent on this, I consider it my failing for not providing contribution guidelines...

@redblobgames unpkg expects a browser build to be available in the npm package. This would force node user to download the browser build along with the module everytime they install the module. From what I see, jsdelivr can serve files directly from the github repository which makes more sense from my point of view. There is also wzrd.in which is able to properly compile npm modules and serve them as bundles for the browser ( https://wzrd.in/standalone/poisson-disk-sampling@latest ) but from my experience this service tends to go offline every now and then.

@kchapelier kchapelier closed this Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.