New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: add info on WAR and static build #19

Merged
merged 2 commits into from Jan 29, 2017

Conversation

Projects
None yet
2 participants
@pdaengeli
Copy link
Contributor

pdaengeli commented Jan 28, 2017

The documentation mentions the possibilities to build to WAR and static (at components.rst), but more specific information is missing.
Let me know if there is a better way to do this than what I sketched here.

Btw, great to see the recent activity here!

Documentation: add info on WAR and static build
The documentation mentions the possibilities to build to `WAR` and `static` (at [`components.rst`](components.rst)), but more specific information is missing. 
Let me know if there is a better way to do this than what I sketched here.

Btw, great to see the recent activity here!
@ajenhl

This comment has been minimized.

Copy link
Contributor

ajenhl commented Jan 28, 2017

No need to change the default target (unless to be able to double-click the BAT file in Windows, I guess; anyone building a WAR or static version of the site is likely to be comfortable using a command shell or similar), just specify the target as an argument:

./build.sh static
./build.sh war

Also, the war target doesn't require the site to be running, as far as I can see. I'll admit that I've never made use of either option on any real project.

@pdaengeli

This comment has been minimized.

Copy link
Contributor

pdaengeli commented Jan 28, 2017

Both commands are working, cool. A hint in the documentation would be helpful, I think, as a static build may be nice to make smaller projects portable and (relatively) future proof.

I agree, the war target should work on its own.

@ajenhl ajenhl merged commit 723683d into kcl-ddh:master Jan 29, 2017

@ajenhl

This comment has been minimized.

Copy link
Contributor

ajenhl commented Jan 29, 2017

Thanks for this contribution!

@pdaengeli pdaengeli deleted the pdaengeli:patch-1 branch Jan 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment