fix: Do not hoist identical version schemas for apiextensions.k8s.io/v1 #142
+1,092
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying k8s api that converts into the final CRD object is deduplicating versions.
With rehydrating the schemas we fix a problem with possible API incompatibility and the generated specs.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
fix APi versions for CRDs are deduplicated and therefore missing newer versions #141
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
the underlying k8s package/method call apiextv1.Convert_v1_CustomResourceDefinition_To_apiextensions_CustomResourceDefinition(crdObj.(*apiextv1.CustomResourceDefinition), crd, nil)
is preventing export of schema versions with same properties.
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
CustomResourceDefinition of apiextensions.k8s.io/v1 now generates multiple files(version) instead of only the first, like all other CRD kinds.
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: