From fc683ba22936c8474aaa56ef49e19eba3c20c1f8 Mon Sep 17 00:00:00 2001 From: Lionel Villard Date: Mon, 30 Jan 2023 16:47:51 -0500 Subject: [PATCH] better error message --- test/e2e/syncer/dns/dns_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/e2e/syncer/dns/dns_test.go b/test/e2e/syncer/dns/dns_test.go index 81669a018fe..af1a5be1a75 100644 --- a/test/e2e/syncer/dns/dns_test.go +++ b/test/e2e/syncer/dns/dns_test.go @@ -120,7 +120,7 @@ func TestDNSResolution(t *testing.T) { framework.Eventually(t, checkLogs(ctx, t, downstreamKubeClient, downstreamWS2NS1, "ping-fully-qualified-fail", "ping: bad"), wait.ForeverTestTimeout, time.Millisecond*500, "Service name was resolved") - t.Log("Change ping-fully-qualified deployment DNS config to use workspace 2 nameserver") + t.Log("Change ping-fully-qualified deployment DNS config to use workspace 2 nameserver and check the DNS name does not resolve") dnsServices, err := downstreamKubeClient.CoreV1().Services(syncer.SyncerID).List(ctx, metav1.ListOptions{}) require.NoError(t, err) require.True(t, len(dnsServices.Items) >= 2) @@ -153,7 +153,7 @@ func TestDNSResolution(t *testing.T) { require.NoError(t, err) framework.Eventually(t, checkLogs(ctx, t, downstreamKubeClient, downstreamWS1NS1, "ping-fully-qualified", "ping: bad"), - wait.ForeverTestTimeout, time.Millisecond*500, "Service name was still not resolved") + wait.ForeverTestTimeout, time.Millisecond*500, "Service name was resolved") } func checkLogs(ctx context.Context, t *testing.T, downstreamKubeClient *kubernetes.Clientset, downstreamNamespace, containerName, expectedPrefix string) func() (success bool, reason string) {