Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 cache: expose the cache-server under "/services/cache" path #1961

Merged

Conversation

p0lyn0mial
Copy link
Contributor

Summary

We already have services/apiexports for accessing resources exposed by the VW server.
This PR adds /services/cache for accessing resources hosted on the cache-server.
Thanks to that the same path will be exposed no matter if the cache-server is running in a standalone mode or in-process with the kcp-server.

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from jmprusi and ncdc September 13, 2022 10:52
@p0lyn0mial
Copy link
Contributor Author

/assign @stevekuznetsov @sttts

@sttts
Copy link
Member

sttts commented Sep 13, 2022

/lgtm
7approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2022
@sttts
Copy link
Member

sttts commented Sep 13, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2022
@ncdc ncdc changed the title 🌱 cache: exposes the cache-server under "/services/cache" path 🌱 cache: expose the cache-server under "/services/cache" path Sep 13, 2022
@openshift-merge-robot openshift-merge-robot merged commit ea31363 into kcp-dev:main Sep 13, 2022
@stevekuznetsov
Copy link
Contributor

#342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants