Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring cleaning #7

Merged
merged 9 commits into from May 13, 2019

Conversation

Projects
None yet
3 participants
@akx
Copy link
Member

commented Apr 28, 2019

  • Drop Django 1.x compatibility
  • Drop Python 2 compatibility
  • Increase test coverage
  • Fix bugs uncovered by better tests

@akx akx added the enhancement label Apr 28, 2019

@akx akx requested a review from japsu Apr 28, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Apr 28, 2019

Codecov Report

Merging #7 into master will increase coverage by 3.28%.
The diff coverage is 97.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   93.15%   96.44%   +3.28%     
==========================================
  Files          10       16       +6     
  Lines         453      478      +25     
  Branches       59        0      -59     
==========================================
+ Hits          422      461      +39     
- Misses         15       17       +2     
+ Partials       16        0      -16
Impacted Files Coverage Δ
lippukala_tests/utils.py 100% <ø> (ø) ⬆️
lippukala_tests/test_lippukala.py 100% <100%> (ø) ⬆️
lippukala/printing.py 100% <100%> (+2.7%) ⬆️
lippukala_tests/test_pos.py 100% <100%> (+11.11%) ⬆️
lippukala_tests/test_admin.py 100% <100%> (ø)
lippukala/models/code.py 93.24% <100%> (ø)
lippukala/reports.py 100% <100%> (ø) ⬆️
lippukala/admin.py 96.87% <100%> (ø)
lippukala_test_app/settings.py 100% <100%> (ø) ⬆️
lippukala/models/__init__.py 100% <100%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fa6e95...81fbd18. Read the comment docs.

@japsu

japsu approved these changes May 10, 2019

@akx akx merged commit 5b79978 into master May 13, 2019

4 checks passed

codecov/patch 97.91% of diff hit (target 93.15%)
Details
codecov/project 96.44% (+3.28%) compared to 7fa6e95
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.