New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Room #11

Merged
merged 4 commits into from Feb 4, 2019

Conversation

Projects
None yet
3 participants
@akx
Copy link
Member

akx commented Feb 4, 2019

Adds a simple Room model for logical grouping, both for Zones and Programs.

This doesn't validate that all Rows in a Program belong to Zones in the Program's Room – that's on the operator at present.

@akx akx added the enhancement label Feb 4, 2019

@akx akx requested a review from japsu Feb 4, 2019

@japsu

japsu approved these changes Feb 4, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 4, 2019

Codecov Report

Merging #11 into master will decrease coverage by 0.55%.
The diff coverage is 85.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   94.31%   93.76%   -0.56%     
==========================================
  Files          23       24       +1     
  Lines         598      625      +27     
==========================================
+ Hits          564      586      +22     
- Misses         34       39       +5
Impacted Files Coverage Δ
paikkala/fields.py 90% <ø> (ø) ⬆️
paikkala/models/tickets.py 78.04% <ø> (ø) ⬆️
paikkala/forms.py 84.09% <ø> (ø) ⬆️
paikkala/models/rows.py 94.87% <0%> (ø) ⬆️
paikkala/utils/importer.py 100% <100%> (ø) ⬆️
paikkala/models/zones.py 100% <100%> (ø) ⬆️
paikkala/tests/conftest.py 100% <100%> (ø) ⬆️
paikkala/models/programs.py 92.77% <100%> (+0.08%) ⬆️
paikkala/models/__init__.py 100% <100%> (ø) ⬆️
paikkala/admin.py 87.8% <76.47%> (-8.63%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db05933...6e5b643. Read the comment docs.

@akx akx merged commit 7983068 into master Feb 4, 2019

2 of 4 checks passed

codecov/patch 85.36% of diff hit (target 94.31%)
Details
codecov/project 93.76% (-0.56%) compared to db05933
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@akx akx deleted the the-room branch Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment