Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upThe Room #11
Conversation
akx
added some commits
Feb 4, 2019
akx
added
the
enhancement
label
Feb 4, 2019
akx
requested a review
from
japsu
Feb 4, 2019
japsu
approved these changes
Feb 4, 2019
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Feb 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
- Coverage 94.31% 93.76% -0.56%
==========================================
Files 23 24 +1
Lines 598 625 +27
==========================================
+ Hits 564 586 +22
- Misses 34 39 +5
Continue to review full report at Codecov.
|
akx
merged commit 7983068
into
master
Feb 4, 2019
akx
deleted the
the-room
branch
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
akx commentedFeb 4, 2019
Adds a simple Room model for logical grouping, both for Zones and Programs.
This doesn't validate that all Rows in a Program belong to Zones in the Program's Room – that's on the operator at present.