New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baikal: do not require same user in test application #13

Merged
merged 1 commit into from Feb 5, 2019

Conversation

Projects
None yet
3 participants
@japsu
Copy link
Member

japsu commented Feb 4, 2019

No description provided.

@japsu japsu requested a review from akx Feb 4, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 4, 2019

Codecov Report

Merging #13 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #13   +/-   ##
=======================================
  Coverage   95.35%   95.35%           
=======================================
  Files          27       27           
  Lines         667      667           
=======================================
  Hits          636      636           
  Misses         31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0218ef...ae15436. Read the comment docs.

@akx
Copy link
Member

akx left a comment

Technically I'm fine with this, but to reduce the surface of the patch, might this be a common enough requirement to warrant a settings setting such as PAIKKALA_INSPECT_VIEW_REQUIRE_SAME_USER (that would default to True)?

@japsu

This comment has been minimized.

Copy link
Member Author

japsu commented Feb 5, 2019

nahhhhh

The integrator is expected to subclass anyway. I don't see this as a relevant installation-wide option.

@akx akx merged commit e459ff3 into master Feb 5, 2019

4 checks passed

codecov/patch Coverage not affected when comparing e0218ef...ae15436
Details
codecov/project 95.35% remains the same compared to e0218ef
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@akx akx deleted the baikal-no-require-same-user branch Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment