Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBackground balance should check full-balance in advance #168
Comments
kdave
added a commit
that referenced
this issue
Aug 20, 2019
Move the full-balance warning to before the fork, so that the user can see and react to it. Notes on test: - Don't use grep -q, as it causes a SIGPIPE during the countdown, and the balance thus doesn't start. - The "balance cancel" is superfluous as the last command, but it provides some idempotence and allows adding more tests below it. Issue: #168 Signed-off-by: Vladimir Panteleev <git@vladimir.panteleev.md> Signed-off-by: David Sterba <dsterba@suse.com>
|
Thanks, patch added to devel. |
kdave
added a commit
that referenced
this issue
Aug 26, 2019
Move the full-balance warning to before the fork, so that the user can see and react to it. Notes on test: - Don't use grep -q, as it causes a SIGPIPE during the countdown, and the balance thus doesn't start. - The "balance cancel" is superfluous as the last command, but it provides some idempotence and allows adding more tests below it. Issue: #168 Signed-off-by: Vladimir Panteleev <git@vladimir.panteleev.md> Signed-off-by: David Sterba <dsterba@suse.com>
kdave
added a commit
that referenced
this issue
Aug 26, 2019
Move the full-balance warning to before the fork, so that the user can see and react to it. Notes on test: - Don't use grep -q, as it causes a SIGPIPE during the countdown, and the balance thus doesn't start. - The "balance cancel" is superfluous as the last command, but it provides some idempotence and allows adding more tests below it. Issue: #168 Signed-off-by: Vladimir Panteleev <git@vladimir.panteleev.md> Signed-off-by: David Sterba <dsterba@suse.com>
kdave
added a commit
that referenced
this issue
Sep 4, 2019
Move the full-balance warning to before the fork, so that the user can see and react to it. Notes on test: - Don't use grep -q, as it causes a SIGPIPE during the countdown, and the balance thus doesn't start. - The "balance cancel" is superfluous as the last command, but it provides some idempotence and allows adding more tests below it. Issue: #168 Signed-off-by: Vladimir Panteleev <git@vladimir.panteleev.md> Signed-off-by: David Sterba <dsterba@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The warning when full-balance is started in the background is pritnted too late, ie. in the forked process and the user does not see it nor is able to react.
To fix that, move the check before the fork in cmds-balance.c:cmd_balance_start