Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While running tests from testsuite: mkfs test failed for case 011-rootdir-create-file #198

Closed
Lakshmipathi opened this issue Aug 21, 2019 · 2 comments
Labels
bug
Milestone

Comments

@Lakshmipathi
Copy link
Contributor

@Lakshmipathi Lakshmipathi commented Aug 21, 2019

I did make testsuite to create tests/btrfs-progs-tests.tar.gz file. After copying this tar and running it from different system mkfs tests fail with below message.

[TEST/mkfs] 011-rootdir-create-file
failed: /usr/local/bin/mkfs.btrfs -f --rootdir /usr/local/bin/Documentation/ btrfs-progs-mkfs.rootdirVSUlvAy
test failed for case 011-rootdir-create-file

Looks like below testcase assume Documentation directory will be always present

$cat 011-rootdir-create-file/test.sh
#!/bin/bash
# Regression test for mkfs.btrfs --rootdir on non-existent file.
# Expected behavior: it should create a new file if destination doesn't exist
# Regression 460e93f25754 ("btrfs-progs: mkfs: check the status of file at mkfs")

source "$TEST_TOP/common"

check_prereq mkfs.btrfs

tmp=$(mktemp -d --tmpdir btrfs-progs-mkfs.rootdirXXXXXXX)
# we can't use TEST_DEV, a file is needed
img=$(mktemp btrfs-progs-mkfs.rootdirXXXXXXX)
run_check "$TOP/mkfs.btrfs" -f --rootdir "$TOP/Documentation/" "$img"

rm -rf -- "$img"

https://gitlab.com/giis/btrfs-progs/-/jobs/275910761

@kdave kdave added the bug label Aug 22, 2019
@kdave
Copy link
Owner

@kdave kdave commented Aug 22, 2019

Right, using Documentation was a lazy solution, we need some data generator instead.

@marcosps
Copy link
Contributor

@marcosps marcosps commented Feb 28, 2020

@Lakshmipathi I believe that bbb3d8f fixed this issue. I tested here and it worked as expected.

@kdave kdave added this to the v5.4.2 milestone Mar 3, 2020
@kdave kdave closed this Mar 3, 2020
kdave added a commit that referenced this issue Mar 3, 2020
There are two utilities that are required for the testsuite but not
installed on systems. The path in tests must be INTERNAL_BIN.

Fix this issue for below tests:
 * fsck-tests/013-extent-tree-rebuild
 * fsck-tests/037-freespacetree-repair
 * misc-tests/038-backup-root-corruption

Issue: #198
Signed-off-by: Long An <lan@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
kdave added a commit that referenced this issue Mar 4, 2020
There are two utilities that are required for the testsuite but not
installed on systems. The path in tests must be INTERNAL_BIN.

Fix this issue for below tests:
 * fsck-tests/013-extent-tree-rebuild
 * fsck-tests/037-freespacetree-repair
 * misc-tests/038-backup-root-corruption

Issue: #198
Signed-off-by: Long An <lan@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
@kdave kdave modified the milestones: v5.4.2, v5.5 Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.