Skip to content

/ btrfs-progs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythons2->python3 update needed for btrfs-debugfs show-blocks #261

Closed
cmurf opened this issue Jun 22, 2020 · 6 comments
Closed

pythons2->python3 update needed for btrfs-debugfs show-blocks #261

cmurf opened this issue Jun 22, 2020 · 6 comments
Labels
enhancement
Milestone
v5.7

Comments

@cmurf
Copy link

@cmurf cmurf commented Jun 22, 2020

The btrfs-debugfs show-blocks scripts included in btrfs-progs fail with python3.

Either they should be updated for python3 if they're still useful, or deprecated.
@Lakshmipathi
Copy link
Contributor

@Lakshmipathi Lakshmipathi commented Jun 22, 2020

I think its a nice little script, let me check the issue with python3.
@Lakshmipathi
Copy link
Contributor

@Lakshmipathi Lakshmipathi commented Jun 22, 2020

I did a quick fix. Could you please check this Lakshmipathi@bb258fc
kdave added a commit that referenced this issue Jun 29, 2020
Lakshmipathi @kdave
btrfs-progs: port btrfs-debugfs to python3
f4fef7d 
There's still some interest in the btrfs-debugfs tool, make it work with
python v3 until we have a replacement.

Issue: #261
Signed-off-by: Lakshmipathi <lakshmipathi.ganapathi@collabora.com>
Signed-off-by: David Sterba <dsterba@suse.com>
@kdave
Copy link
Owner

@kdave kdave commented Jun 29, 2020

I've applied the commit to devel, thanks.
@kdave kdave closed this Jun 29, 2020
@kdave kdave added the enhancement label Jun 29, 2020
@kdave kdave added this to the v5.7 milestone Jun 29, 2020
kdave added a commit that referenced this issue Jun 29, 2020
Lakshmipathi @kdave
btrfs-progs: port btrfs-debugfs to python3
1c03aae 
There's still some interest in the btrfs-debugfs tool, make it work with
python v3 until we have a replacement.

Issue: #261
Signed-off-by: Lakshmipathi <lakshmipathi.ganapathi@collabora.com>
Signed-off-by: David Sterba <dsterba@suse.com>
@Lakshmipathi
Copy link
Contributor

@Lakshmipathi Lakshmipathi commented Jun 29, 2020

@kdave Sorry I missed to update the latest patch link. Its Lakshmipathi@40a1a57 could you please use this patch or should I send the patch to mailing-list? Couple of issues caught by @zabbo Lakshmipathi@bb258fc#commitcomment-40074172 and tested by @cmurf thanks!
@kdave kdave reopened this Jun 29, 2020
@kdave
Copy link
Owner

@kdave kdave commented Jun 29, 2020

Ok thanks, I'll update patch for final 5.7.
@kdave
Copy link
Owner

@kdave kdave commented Jul 2, 2020

Updated in devel.
@kdave kdave closed this Jul 2, 2020
kdave added a commit that referenced this issue Jul 2, 2020
Lakshmipathi @kdave
btrfs-progs: port btrfs-debugfs to python3
43b8ceb 
There's still some interest in the btrfs-debugfs tool, make it work with
python v3 until we have a replacement.

Issue: #261
Signed-off-by: Lakshmipathi <lakshmipathi.ganapathi@collabora.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v5.7
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@Lakshmipathi @kdave @cmurf
You can’t perform that action at this time.