Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes merge for #59, #174, and #175 #181

Open
wants to merge 17 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@unquietwiki
Copy link

commented Jun 12, 2019

@kdave this seems like a lot; but honestly, I've made worse commits to other projects. The only one that I'm actually iffy on is the utils.c changes: the fallthrough method I borrowed appears to be a port of what happens in C++17, but might still need yours/their sign off.

@unquietwiki

This comment has been minimized.

Copy link
Author

commented Jun 12, 2019

And I've been using this changeset live on a ~90TB recovery effort. My problem so far has been getting my NFS target to absorb the amount of data I'm throwing at it! 💯

@unquietwiki

This comment has been minimized.

Copy link
Author

commented Jun 27, 2019

@kdave Checking back on this: memory usage on my restore project has been pretty consistent; not seeing any major memory leakage. I do notice it's a lot more responsive to restore onto an SMB mount than an NFS mount (keeps overloading the latter).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.