Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes merge for #59, #174, and #175 #181
Conversation
|
And I've been using this changeset live on a ~90TB recovery effort. My problem so far has been getting my NFS target to absorb the amount of data I'm throwing at it! |
|
@kdave Checking back on this: memory usage on my restore project has been pretty consistent; not seeing any major memory leakage. I do notice it's a lot more responsive to restore onto an SMB mount than an NFS mount (keeps overloading the latter). |
|
@kdave did any of these changes make it into 5.3.x ? I saw there was mention of "printf fixes" that I do recall working on. |
|
#175 has been merged, the other two partially so fart |
|
@kdave thanks! If you need me to do any more work on this, I can try to make that happen. |
unquietwiki commentedJun 12, 2019
@kdave this seems like a lot; but honestly, I've made worse commits to other projects. The only one that I'm actually iffy on is the utils.c changes: the fallthrough method I borrowed appears to be a port of what happens in C++17, but might still need yours/their sign off.