kernel-shared/uapi/btrfs.h: fix BTRFS_IOC_SCAN_DEV #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the change `BTRFS_IOC_SCAN_DEV` aliased with `BTRFS_IOC_FORGET_DEV`. It's a regression introduced in fcd9142 "btrfs-progs: docs: formatting, fixups, updates". It manifests as a sudden device disappearance when device is scanned: machine # [ 4.095032] Btrfs loaded, crc32c=crc32c-intel, zoned=no, fsverity=no machine # ERROR: device scan failed on '/dev/vdb': No such file or directory machine # ERROR: device scan failed on '/dev/vdc': No such file or directory (finished: must succeed: mkfs.btrfs -d raid0 /dev/vdb /dev/vdc, in 10.31 seconds) Reported-by: Atemu <atemu.main@gmail.com> Bug: NixOS/nixpkgs#265668
Owner
Oh crap, that was an accidental edit in |
kdave
pushed a commit
that referenced
this pull request
Nov 5, 2023
Without the change `BTRFS_IOC_SCAN_DEV` aliased with `BTRFS_IOC_FORGET_DEV`. It's a regression introduced in fcd9142 "btrfs-progs: docs: formatting, fixups, updates". It manifests as a sudden device disappearance when device is scanned: machine # [ 4.095032] Btrfs loaded, crc32c=crc32c-intel, zoned=no, fsverity=no machine # ERROR: device scan failed on '/dev/vdb': No such file or directory machine # ERROR: device scan failed on '/dev/vdc': No such file or directory (finished: must succeed: mkfs.btrfs -d raid0 /dev/vdb /dev/vdc, in 10.31 seconds) Issue: #704 Pull-request: #706 Reported-by: Atemu <atemu.main@gmail.com> Bug: NixOS/nixpkgs#265668 Author: Sergei Trofimovich <slyich@gmail.com> Signed-off-by: David Sterba <dsterba@suse.com>
Owner
|
Merged and released as v6.6.1, thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the change
BTRFS_IOC_SCAN_DEValiased withBTRFS_IOC_FORGET_DEV. It's a regression introduced in fcd9142 "btrfs-progs: docs: formatting, fixups, updates".It manifests as a sudden device disappearance when device is scanned:
Reported-by: Atemu atemu.main@gmail.com
Bug: NixOS/nixpkgs#265668