fix(emoji): don't remove single colons #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fleesk
force-pushed
the
fix-emoji-colons
branch
from
3db0023 to
235a2ba
Compare
5 tasks
Owner
|
Thanks for the PR! I imagine using length like that for emojis may cause issues with some emojis though. But this is a good fix for now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of remove-emojis.lua removes tokens in the pandoc tree that are just single or double colons. For example, the file
is transformed into
The shortest github emojis are 3 characters (including the colons), so removing anything shorter than that won't match them. By only removing strings that start & end with ":" and are at least 3 characters long, the output for situations like the example above is fixed and includes the colons.
To more accuractely remove only github emoji and no other tokens surrounded by colons, you could make use of https://api.github.com/emojis to get an up-to-date list, but that might be a bit overkill.