[Windows] Crash in native code tray_get_notification_icons_position on some Windows systems

[badmannersteam]

ComposeNativeTray version: 0.8.10
JDK: JBR 21.0.7

Stacktrace:

java.lang.Error: Invalid memory access
    at com.kdroid.composetray.lib.windows.WindowsNativeTrayLibrary.tray_get_notification_icons_position(WindowsNativeTrayLibrary.kt:0)
    at com.kdroid.composetray.lib.windows.WindowsTrayManager.runMessageLoop(WindowsTrayManager.kt:172)
    at com.kdroid.composetray.lib.windows.WindowsTrayManager.initialize$lambda$3$lambda$1(WindowsTrayManager.kt:114)
    at java.lang.Thread.run

Unfortunately this is the only info I have from production Sentry logs for now.
Looks like issue is not very frequent, but happens on some Windows systems.

I will try to add more info when find some users with that crash and check with version 0.9.0.

[badmannersteam]

just a thought - maybe here we need to init uFlags explicitly?
Because if not set explicitly it potentially can be a NIF_GUID, that forces NotifyIconGetRect to read the guidItem and fail on dereference.

NOTIFYICONIDENTIFIER nii = { sizeof(nii) };
nii.hWnd = l_hwnd;
nii.uID  = l_uid;

nii.uFlags = 0;    // fix

[acarlsen]

I have experienced the same issue on fresh install of Windows 11 using version 0.9.0 (same stacktrace).

Version 0.8.9 works fine.

[kdroidFilter]

@badmannersteam @acarlsen Hi, thanks you for your repport, can you check with 0.9.1 ?
Thanks a lot !

[badmannersteam]

@kdroidFilter i can't reproduce this myself, but i share a build with 0.9.1 to a couple of users with this crash and they tell that app works fine now.
so at least it doesn't crash anymore :D
thanks for the fix.