Skip to content

Add DrawableResource icon support + fixes for issues #206 and #286#289

Merged
kdroidFilter merged 8 commits into
masterfrom
dev
Sep 11, 2025
Merged

Add DrawableResource icon support + fixes for issues #206 and #286#289
kdroidFilter merged 8 commits into
masterfrom
dev

Conversation

@kdroidFilter

@kdroidFilter kdroidFilter commented Sep 11, 2025

Copy link
Copy Markdown
Owner

This PR introduces the following changes:

  1. Support for DrawableResource icons in Tray and TrayApp APIs
  2. Overloaded methods in Tray and TrayApp to handle the new icon type, with multiplatform compatibility.
  3. Unicode compatibility improvements — adds a UnicodeTrayDemo showcasing menus with accented characters, non-Latin scripts, and special symbols.
  4. Robustness and safety fixes, especially on Windows:
      • Initialize NOTIFYICONIDENTIFIER to zero to prevent undefined behavior.
      • Added null checks and improved memory/pointer safety.
      • Extracted reusable logic (e.g., tray position calculation) to reduce duplication.
  5. Updated dependencies and documentation to reflect the new DrawableResource support and demos.

Fixed issues: #206, #286

…ntations, and update dependencies for resource handling.
…u icons, including usage examples and demos.
…DrawableResource` and `ImageVector` icons.
…ay menus

- Introduced `UnicodeTrayDemo` showcasing a tray menu with French, Chinese, and mixed Unicode items.
- Validates UTF-8 to UTF-16 handling and rendering across platforms.
- Includes examples of accented letters, non-Latin scripts, and symbols in a multi-language context.
Zero-initialize NOTIFYICONIDENTIFIER in tray_windows.c to prevent undefined behavior, ensuring compatibility with Windows APIs. Refactored WindowsTrayManager to improve safety, including null pointer checks, better error handling for memory access issues, and extraction of reusable `safeGetTrayPosition` logic. Updated binaries to reflect these critical fixes.
@kdroidFilter kdroidFilter changed the title Fix #206 and #286 Add DrawableResource icon support + fixes for issues #206 and #286 Sep 11, 2025
@kdroidFilter kdroidFilter merged commit 2df539e into master Sep 11, 2025
@kdroidFilter kdroidFilter deleted the dev branch September 30, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant