UI: default properties look too similar to properties set to an empty string

[ericwa]

It's hard to see that "style" is set to the empty string here:

I'd suggest drawing the default property keys in gray text, or maybe make the keys that the user set bold.

Here is quark for comparison, the icons make it easier to see which keys are defaults IMO:

[kduske]

@ericwa could you have a look at branch feature/1444 and let me know how that works?

[ericwa]

That looks great, thanks!

[kduske]

Great. While we're at it: When you select multiple entities, the table will show the union of all the entities' properties. Do you think we should visually set those properties apart that only a subset of the entities has from those properties that all the entities have? The reason is that changing one of the former will add that property to all selected entities that didn't have it before.

[ericwa]

Yeah, that would be good.

I just checked Quark. Properties in a multiple selection which are set on only a subset of entities have the icon greyed out, which is the same visual indication that it uses for default properties (but default properties aren't shown in Quark when you have a multiple selection.)

^ both entities have "angle" "360", the light is the only one with "light" set.

Also, showing some indication like "- differs -" would be good, currently TB just shows a blank when the entities in the selection have different values:

[kduske]

Agree on both counts, and I have set the colour of property subsets to light gray.

As for showing a placeholder text (I prefer multi over differs, the problem with that is that it's fake. When you click on the property to edit it, the initial value will be multi, which I dislike. I would prefer if the initial value was empty when you start editing. This would probably be possible with a custom cell editor, but to be honest I'm too lazy for that right now.

I have implemented the faked version in the last commit. What do you think? Maybe it's still better than having the field blank all the time.

[ericwa]

Nice. Just tried it, I think the fake implementation for "multi" is better than a blank field.

My only remaining nitpick is that selecting a row hides the text color. I have two entities selected, with only one having the "light" key set:

But if that row is selected, it looks like both entities have it set:

I'm not sure what to suggest, other than using bold like Xcode does. Could make the property editor look more visually busy, though.

[kduske]

That's impossible with the wxGrid I think.

[ericwa]

It's possible to make text bold in EntityAttributeGridTable::GetAttr by doing attr->SetFont(GetView()->GetFont().Bold());:

To clarify: what I was suggesting is, for any text that is currently rendered in black, additionally make it bold, so that it's unambiguous even when there is a selection in the table.

Not sure if you like the look of that though.

[kduske]

I had tried that, not too fond of the look tbh.

[kduske]

I have changed the default attributes to be italic in addition to being light gray. This sets them apart when selected, too. What do you think?

[ericwa]

Nice. I think it's good enough to not cause confusion

[kduske]

Alright, I'll merge it.