Don't crash when user selects wrong map format

[negke]

Sigh, okay.

Trying to open Shamblernaut's Retro jam5 map, current TB2 beta crashes due to the brush syntax. The map was saved with J.A.C.K.

Error message: Expected integer or decimal, but got '[' (raw data '[') [line 33, column 66]

Brush syntax looks like this:
( 3584 -4096 3840 ) ( 3584 -4096 -3840 ) ( 3584 3840 3840 ) SKY4 [ 0 -1 -0 0 ] [ 0 0 -1 0 ] 0 1 1

Crash report: trenchbroom-crash.txt

[kduske]

Did you select "Valve" map format when you opened the file? Because it works for me when I do.

[negke]

D'oh. Yes, that works. I ignored that selection box, because I was under the impression it's only needed if the map has a .wcf or .rmf (or what it is) extension....
Still, I suppose it shouldn't outright crash if loading a file in the wrong format.

[kduske]

Yeah, that's true.

[kduske]

@ericwa I don't have access to a Windows machine at the moment. Could you have a look at this?

[ericwa]

Sure. I tested with https://ci.appveyor.com/api/buildjobs/kll2h75ca7talv1s/artifacts/cmakebuild%2FTrenchBroom-Win32-2.0.0-Interim-0e1a90a-RelWithDebInfo.7z

It doesn't crash; I get the parse error dialog box, and then I opened the map again as valve, and it worked.

Autodetecting the format would be a nice improvement, but I guess this crash was fixed by some other change.

[kduske]

Same here. Thanks for checking!

[ericwa]

Hmm, now I can reproduce this on fd7b50e on a debug build on Windows, seems to be some kind of invalid read where MapFrame gets activated after its destructor runs.