Bug 370030: Ensure that favorites service is instantiated before tryi…

…ng to get it from the services registry.
kdvolder · Jan 28, 2012 · ae396ea · ae396ea
1 parent 6d071e1
commit ae396ea
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/bundles/org.eclipse.orion.client.core/web/orion/widgets/OpenResourceDialog.js b/bundles/org.eclipse.orion.client.core/web/orion/widgets/OpenResourceDialog.js
@@ -13,8 +13,8 @@
 /*jslint browser:true*/
 /*global define orion window dojo dijit*/
 
-define(['require', 'dojo', 'dijit', "orion/util", 'dijit/Dialog', 'dijit/form/TextBox', 
-		'orion/widgets/_OrionDialogMixin', 'text!orion/widgets/templates/OpenResourceDialog.html'], function(require, dojo, dijit, mUtil) {
+define(['require', 'dojo', 'dijit', "orion/util", 'orion/favorites', 'dijit/Dialog', 'dijit/form/TextBox', 
+		'orion/widgets/_OrionDialogMixin', 'text!orion/widgets/templates/OpenResourceDialog.html'], function(require, dojo, dijit, mUtil, mFavorites) {
 
 /**
  * Usage: <code>new widgets.OpenResourceDialog(options).show();</code>
@@ -51,6 +51,10 @@ var OpenResourceDialog = dojo.declare("orion.widgets.OpenResourceDialog", [dijit
 			throw new Error("Missing required argument: serviceRegistry");
 		}
 		this.favService = serviceRegistry.getService("orion.core.favorite");
+		if (!this.favService) {
+			new mFavorites.FavoritesService({serviceRegistry: serviceRegistry});
+			this.favService = serviceRegistry.getService("orion.core.favorite");
+		}
 	},
 
 	/** @private */