Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Nuke.loadImage image is not displayed when .fadeIn transition is used #206

Closed
gabors opened this issue Dec 18, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@gabors
Copy link

commented Dec 18, 2018

Looks like on macOS this never displays an image if I use a fadeIn transition

Nuke.loadImage( with: imageRequest, options: ImageLoadingOptions( placeholder: placeholderImage, transition: .fadeIn(duration: 0.33) ), into: imageView)
yet on iOS/tvOS it works great.
On macOS as soon as I remove the whole options parameter, images show up fine.

@kean

This comment has been minimized.

Copy link
Owner

commented Dec 18, 2018

Seems be an issue with fade transition on macOS, would appreciate an MR.

@gabors

This comment has been minimized.

Copy link
Author

commented Dec 18, 2018

Простите а "MR" енто что?

@gabors

This comment has been minimized.

Copy link
Author

commented Dec 18, 2018

Looked at your code for the macOS fade transition.
Will try to make it work.

actually maybe can use this https://github.com/steve228uk/PeachMac/blob/master/Peach/NSImageView%2BTransition.swift

@kean

This comment has been minimized.

Copy link
Owner

commented Dec 18, 2018

Sorry, I got used to the terminology we use at work (MR - Merge Request). PR - Pull Request.

Yep, seems perfect, I think that's what I'm using except that I forgot to display the actual image 😁

@gabors

This comment has been minimized.

Copy link
Author

commented Dec 18, 2018

Lol. Happens.

@kean kean added the bug label Dec 24, 2018

@kean kean changed the title macOS Nuke.loadImage [macOS] Nuke.loadImage image is not displayed when .fadeIn transition is used Dec 26, 2018

@kean

This comment has been minimized.

Copy link
Owner

commented Dec 26, 2018

Fixed in 7.5.2

@kean kean closed this Dec 26, 2018

@kean kean added this to the 7.5.2 milestone Dec 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.